[tor-bugs] #9221 [Obfsproxy]: obfsproxy does not have a SOCKS5 listener

[Tor Bug Tracker & Wiki]

#9221: obfsproxy does not have a SOCKS5 listener
---------------------------+------------------------------
     Reporter:  JBennett   |      Owner:  asn
         Type:  defect     |     Status:  needs_review
     Priority:  normal     |  Milestone:
    Component:  Obfsproxy  |    Version:  Obfsproxy: 0.1.4
   Resolution:             |   Keywords:
Actual Points:             |  Parent ID:
       Points:             |
---------------------------+------------------------------

Comment (by yawning):

 Not the best tests, but this is fairly comprehensive.

 Places I skimped:
  * Only tested SOCKSv5Protocol, the Outgoing class is boilerplate and is
 mostly unchanged from the old SOCKSv4 code.
  * Only tested one of the exception to SOCKSv5 response mappings.
  * Didn't bother testing short writes where the server would need to
 buffer and wait for more data.

 Probably good enough for now since it's a massive improvement over what
 exists (both the Twisted SOCKSv5 code and what was in obfsproxy).

 https://github.com/Yawning/obfsproxy/commit/fe3a0b2820e8e68543ef1c7aa6f3ffa1d572fb9c

 Let me know if there are any other changes I should make, if not, I'll
 make a cleaned up branch with the bulk of the commits I made actually
 implementing all this squashed down.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9221#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online