[tor-bugs] #10893 [Pluggable transport]: ScrambleSuit spec improvements

[Tor Bug Tracker & Wiki]

#10893: ScrambleSuit spec improvements
-------------------------------------+-------------------------------
     Reporter:  yawning              |      Owner:  phw
         Type:  defect               |     Status:  needs_review
     Priority:  normal               |  Milestone:
    Component:  Pluggable transport  |    Version:
   Resolution:                       |   Keywords:  scramblesuit spec
Actual Points:                       |  Parent ID:
       Points:                       |
-------------------------------------+-------------------------------

Comment (by yawning):

 UniformDH handshake documentation:
 > HMAC-SHA256-128(k_B, X | P_C | E)

 Should be updated to include M_C.

 Session Ticket documentation:
 > MAC = HMAC-SHA256-128(k_sh, T | P | E)

 > |  T | P | M | MAC(T | P | E)  |     T: session ticket

 > server then verifies the MAC which is built over T | P | E.

 The HMAC generation includes the mark like in the UniformDH case and
 should be documented as such (See ticket.py:62).

 Everything else looks good to me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10893#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online