[tor-bugs] #11010 [Tor]: add ClientConnectPolicy config option

[Tor Bug Tracker & Wiki]

#11010: add ClientConnectPolicy config option
-----------------------------+--------------------------------
     Reporter:  cypherpunks  |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-client
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------

Comment (by cypherpunks):

 I uploaded a second patch for review. I think this version is good, but I
 still don't understand the purpose or effect of the {{{!conn->use_begindir
 && !conn->chosen_exit_name && !circ}}} expression I copy+pasted from
 {{{consider_plaintext_ports}}}.

 (Btw, the problem with the first patch was that I wasn't checking the
 result of {{{tor_addr_parse}}}, so when a hostname was parsed an
 uninitialized {{{addr}}} was being considered. The confusing thing was
 that, on my system, the uninitialized {{{addr}}} actually ''did'' match
 the {{{reject *:*}}} policy, which caused me to believe the patch worked.
 But when someone else tested it, on their system tor would log a warning
 {{{tor_addr_is_null(): Bug: Called with unknown address family}}} and
 would then fail open because the uninitialized addr didn't match any
 policy.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11010#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online