[tor-bugs] #9221 [Obfsproxy]: obfsproxy does not have a SOCKS5 listener

[Tor Bug Tracker & Wiki]

#9221: obfsproxy does not have a SOCKS5 listener
---------------------------+------------------------------
     Reporter:  JBennett   |      Owner:  asn
         Type:  defect     |     Status:  needs_review
     Priority:  normal     |  Milestone:
    Component:  Obfsproxy  |    Version:  Obfsproxy: 0.1.4
   Resolution:             |   Keywords:
Actual Points:             |  Parent ID:
       Points:             |
---------------------------+------------------------------

Comment (by asn):

 Haven't thoroughly reviewed the code yet, but some comments from skimming
 it:

 - We will need to write unit tests. I would like good code coverage. I can
 definitely help write those if you want.

 - Instead of inlining `struct.pack` and `struct.unpack`, it might be
 better to define some higher-level functions (like `get_uint16()`,
 `set_uint8()`, etc.) in `obfsproxy/common/serialize.py` and use those
 instead. Might make the code more readable.

 - I wonder how much effort would be to submit this upstream. We would have
 to fit the Twisted API.

 More review coming soon.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9221#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online