[tor-bugs] #12400 [Tor bundles/installation]: Rewrite fix-info-plist.sh with Python plistlib

[Tor Bug Tracker & Wiki]

#12400: Rewrite fix-info-plist.sh with Python plistlib
------------------------------------------+--------------------------
     Reporter:  dcf                       |      Owner:  dcf
         Type:  enhancement               |     Status:  needs_review
     Priority:  minor                     |  Milestone:
    Component:  Tor bundles/installation  |    Version:
   Resolution:                            |   Keywords:
Actual Points:                            |  Parent ID:
       Points:                            |
------------------------------------------+--------------------------
Changes (by dcf):

 * status:  new => needs_review


Comment:

 Here's a patch. plistlib canonicalizes indentation and order, so the
 before–after diff is not empty, but the meaning is the same. In this diff,
 directory 1 is built with fix-info-plist.sh, and directory is with fix-
 info-plist.py.

 {{{
 diff -Nru 1/Contents/Info.plist 2/Contents/Info.plist
 --- 1/Contents/Info.plist       2000-01-01 00:00:00.000000000 +0000
 +++ 2/Contents/Info.plist       2000-01-01 00:00:00.000000000 +0000
 @@ -1,5 +1,5 @@
  <?xml version="1.0" encoding="UTF-8"?>
 -<!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN"
 "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 +<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN"
 "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
  <plist version="1.0">
  <dict>
         <key>CFBundleDevelopmentRegion</key>
 @@ -51,7 +51,7 @@
                 <dict>
                         <key>CFBundleTypeExtensions</key>
                         <array>
 -                           <string>text</string>
 +                               <string>text</string>
                                 <string>txt</string>
                                 <string>js</string>
                                 <string>log</string>
 @@ -158,8 +158,6 @@
         <string>APPL</string>
         <key>CFBundleShortVersionString</key>
         <string>4.0-alpha1-pre</string>
 -       <key>NSHumanReadableCopyright</key>
 -       <string>Tor Browser 4.0-alpha1-pre Copyright 2014 The Tor
 Project</string>
         <key>CFBundleSignature</key>
         <string>MOZB</string>
         <key>CFBundleURLTypes</key>
 @@ -203,8 +201,6 @@
         </array>
         <key>CFBundleVersion</key>
         <string>2400.1.1</string>
 -       <key>NSAppleScriptEnabled</key>
 -       <true/>
         <key>LSApplicationCategoryType</key>
         <string>public.app-category.productivity</string>
         <key>LSMinimumSystemVersion</key>
 @@ -216,10 +212,15 @@
                 <key>x86_64</key>
                 <string>10.6.0</string>
         </dict>
 -  <key>NSSupportsAutomaticGraphicsSwitching</key>
 -  <true/>
 -  <key>NSPrincipalClass</key>
 -  <string>GeckoNSApplication</string>
 -  <key>NSDisablePersistence</key><true/>
 +       <key>NSAppleScriptEnabled</key>
 +       <true/>
 +       <key>NSDisablePersistence</key>
 +       <true/>
 +       <key>NSHumanReadableCopyright</key>
 +       <string>Tor Browser 4.0-alpha1-pre Copyright 2014 The Tor
 Project</string>
 +       <key>NSPrincipalClass</key>
 +       <string>GeckoNSApplication</string>
 +       <key>NSSupportsAutomaticGraphicsSwitching</key>
 +       <true/>
  </dict>
  </plist>
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12400#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online