[tor-bugs] #12227 [Tor]: ASan stack-buffer-overflow in prune_v2_cipher_list -- not exploitable

[Tor Bug Tracker & Wiki]

#12227: ASan stack-buffer-overflow in prune_v2_cipher_list  -- not exploitable
---------------------------+-------------------------------------
     Reporter:  starlight  |      Owner:
         Type:  defect     |     Status:  needs_revision
     Priority:  normal     |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor        |    Version:  Tor: 0.2.4.22
   Resolution:             |   Keywords:  tor-client 024-backport
Actual Points:             |  Parent ID:
       Points:             |
---------------------------+-------------------------------------

Comment (by nickm):

 But SSLv23_method() exposes ssl23_get_cipher_by_char().  To get
 ssl3_get_cipher_by_char(), we either need to poke inside openssl
 internals, or get it from SSLv3_method() or TLSv1_method(), I think.

 (In the long term, I think the right decision is to drop support for the
 Tor V2 link protocol handshake entirely, so we can remove this whole
 function.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12227#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online