[tor-bugs] #12195 [- Select a component]: Match channel and circid, not just circid

[Tor Bug Tracker & Wiki]

#12195: Match channel and circid, not just circid
------------------------------------+------------------------------------
 Reporter:  nickm                   |          Owner:
     Type:  defect                  |         Status:  new
 Priority:  normal                  |      Milestone:  Tor: 0.2.5.x-final
Component:  - Select a component    |        Version:
 Keywords:  024-backport tor-relay  |  Actual Points:
Parent ID:                          |         Points:
------------------------------------+------------------------------------
 In one or two places in the code, we try to tell which circuit a cell is
 on doing something like:

 {{{
   if (!CIRCUIT_IS_ORIGIN(circ) &&
       cell->circ_id == TO_OR_CIRCUIT(circ)->p_circ_id) {
 }}}

 But that's wrong!  There is no reason at all a circuit cannot have
 p_circ_id == n_circ_id.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12195>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online