[tor-bugs] #12684 [Firefox Patch Issues]: Make "Not Now" the default button for TorBrowser's canvas permission dialogue

[Tor Bug Tracker & Wiki]

#12684: Make "Not Now" the default button for TorBrowser's canvas permission
dialogue
-------------------------------------+-------------------------------------
     Reporter:  isis                 |      Owner:  mikeperry
         Type:  defect               |     Status:  needs_review
     Priority:  critical             |  Milestone:
    Component:  Firefox Patch        |    Version:
  Issues                             |   Keywords:  tbb-usability, tbb-
   Resolution:                       |  linkability
Actual Points:                       |  Parent ID:
       Points:                       |
-------------------------------------+-------------------------------------
Changes (by isis):

 * status:  needs_revision => needs_review


Comment:

 I have a new patch for this. I'm going to combine it with the proposed
 patch for #7265 and try to build.

 The patch is [https://github.com/isislovecruft/tor-
 browser/commit/17323c3716366d485288803b5906214f777525a4 this commit] in my
 `tor-browser` repo in the `bug12684-canvas-dialogue-order` branch. It
 requires
 [https://github.com/isislovecruft/torbutton/commit/368e74d62df349b27cf578525c3fa15da19ccdc2
 an additional patch] to TorButton to add necessary UI strings.

 I've also added
 [https://github.com/isislovecruft/torbutton/commit/355caac97e0bd417a90602ed268adc0aa9a4f5e0
 another TorButton patch] to clarify the explanation strings, and
 decapitalise some of the other strings in this UI (to make them match
 Mozilla's casing). Both TorButton patches are in my `bug12684-additional-
 canvas-ui-strings`
 [https://github.com/isislovecruft/torbutton/tree/bug12684-additional-
 canvas-ui-strings branch].

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12684#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online