[tor-bugs] #12640 [Tor]: Entry guard unittest (#12207) fail in out-of-tree builds

[Tor Bug Tracker & Wiki]

#12640: Entry guard unittest (#12207) fail in out-of-tree builds
-----------------------+------------------------------------
 Reporter:  asn        |          Owner:
     Type:  defect     |         Status:  new
 Priority:  normal     |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor        |        Version:
 Keywords:  tor-guard  |  Actual Points:
Parent ID:             |         Points:
-----------------------+------------------------------------
 In the unittests introduced by #12207, I'm reading a file containing some
 fake descriptors.

 The file is at `/src/test/test_descriptors.txt` and when I'm loading it in
 the code, I do:
 {{{
 static void *
 fake_network_setup(const struct testcase_t *testcase)
 {
   /* This is the file containing our test descriptors. */
   const char *fname = BUILDDIR "/src/test/test_descriptors.txt";
 }}}

 But apparently, the `BUILDDIR` macro was completely wrong there, since I
 was looking for the root of the source directory, whereas `BUILDDIR` is
 the directory we are building (who would have thought). Apparently, this
 breaks the unittests in the out-of-tree builds of jenkins.

 We should probably find the right macro to use there. I didn't find a
 `SRCDIR` in `config.log` but maybe `autotools` already have something for
 us?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12640>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online