[tor-bugs] #3455 [Firefox Patch Issues]: Tor Browser should set SOCKS username for a request based on first party domain

[Tor Bug Tracker & Wiki]

#3455: Tor Browser should set SOCKS username for a request based  on first party
domain
-------------------------------------+-------------------------------------
     Reporter:  mikeperry            |      Owner:  mikeperry
         Type:  enhancement          |     Status:  needs_review
     Priority:  major                |  Milestone:  TorBrowserBundle
    Component:  Firefox Patch        |  2.3.x-stable
  Issues                             |    Version:
   Resolution:                       |   Keywords:  tbb-linkability, tbb-
Actual Points:                       |  usability, MikePerry201407R
       Points:                       |  Parent ID:  #5752
-------------------------------------+-------------------------------------

Comment (by arthuredelstein):

 Replying to [comment:38 gk]:
 > Re part1/3: What is the reasoning behind renaming ApplyFilter()? Can't
 we just leave it? That would break less things e.g. in the accompanying
 unittest: https://mxr.mozilla.org/mozilla-
 esr24/source/netwerk/test/unit/test_protocolproxyservice.js

 It's true that the method
 {{{
   applyFilter: function(pps, uri, pi) {
      return pps.newProxyInfo("http", "localhost", 8080, 0, 10,
                              pps.newProxyInfo("direct", "", -1, 0, 0,
 null));
   }
 }}}
 doesn't break if we keep the name ApplyFilter, because the second argument
 is ignored. But still, pedantically speaking, the second argument's name
 should be changed to `channel`. So I thought that by changing the method
 name we could ensure that anyone implementing nsIProtocolProxy is forced
 to re-examine their code. But maybe this is too paternalistic. ;)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3455#comment:39>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online