[tor-bugs] #10758 [Tor]: Stop serving version 2 directory information by default
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Jan 30 16:02:55 UTC 2014
#10758: Stop serving version 2 directory information by default
-----------------------------+--------------------------------
Reporter: karsten | Owner:
Type: enhancement | Status: needs_review
Priority: normal | Milestone: Tor: 0.2.5.x-final
Component: Tor | Version:
Resolution: | Keywords:
Actual Points: | Parent ID:
Points: |
-----------------------------+--------------------------------
Comment (by nickm):
Replying to [comment:9 karsten]:
> Your branch bug10758 looks good. I tweaked it a bit in my force-updated
bug10758 branch.
Looks okay to me.
> I also ran my bug10758 branch in a Shadow network with 20 relays which
worked without obvious issues.
Okay. That's not likely to turn up all possible errors, since any weird
stuff that breaks is going to break because of:
* Older versions of Tor
* Nodes what not all authorities find out about
* Directories going up and down
* Other stuff
But it's better than no testing at all.
> With respect to nodelist.c and routerlist.c, I'm not really sure which
functionality you'd want to keep. Can you be more specific, e.g., which
functions would you want to reimplement for v3?
Well, I'm mostly hoping for a review of all the complex pieces and subtle
little lines there to make sure they didn't do something crucial that
wasn't related to the v2 networkstatus system.
Here are some examples:
* v2_ns_dl_status didn't have some extra unexpected meaning, did it?
* Did anything bad just happen to routerlist_remove_old_routers?
I think the answers are "no", but that was some complex logic I just
chopped out.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10758#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list