[tor-bugs] #10095 [TorBrowserButton]: Setting screen resolution to a multiple of 200 x 100 is not working reliably with patch in #8478

[Tor Bug Tracker & Wiki]

#10095: Setting screen resolution to a multiple of 200 x 100 is not working
reliably with patch in #8478
----------------------------+----------------------------------------------
     Reporter:  gk          |      Owner:  mikeperry
         Type:  defect      |     Status:  needs_review
     Priority:  critical    |  Milestone:
    Component:              |    Version:
  TorBrowserButton          |   Keywords:  tbb-fingerprinting, tbb-testcase
   Resolution:              |  Parent ID:
Actual Points:              |
       Points:              |
----------------------------+----------------------------------------------

Comment (by intrigeri):

 Replying to [comment:23 cypherpunks]:
 > Wait a sec, Tails ships Adblock Plus, right?

 Correct.

 > Maybe retry with ''that'' icon removed from the toolbar...

 Tails hides the ABP icon with
 `extensions.adblockplus.showintoolbar=false`.
 We also hide the HTTPS Everywhere and Foxyproxy toolbar icons via
 `userChrome.css`.

 With normal sized icons:

 * Tails 0.22.1~rc1 + the new patch: **fail**
 * Tails 0.22.1~rc1 + the new patch; ABP, Cookie Monster and FoxyProxy
 disabled: **fail**
 * Tails 0.22.1~rc1 + the new patch; NoScript and HTTPS Everywhere
 disabled: **fail**
 * Tails 0.22.1~rc1 + the new patch; ABP, Cookie Monster, FoxyProxy,
 NoScript and HTTPS Everywhere disabled: **success**

 So indeed, it seems that some extension of ours might be messing up with
 the toolbar size in a way that Torbutton does not detect.

 I've not tried disabling add-ons in small icons mode (since it works fine
 with all extensions enabled + the new patch).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10095#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online