[tor-bugs] #10834 [BridgeDB]: Configurable reCAPTCHA remoteip

[Tor Bug Tracker & Wiki]

#10834: Configurable reCAPTCHA remoteip
-----------------------------+--------------------------------------------
     Reporter:  sysrqb       |      Owner:  isis
         Type:  enhancement  |     Status:  accepted
     Priority:  normal       |  Milestone:
    Component:  BridgeDB     |    Version:
   Resolution:               |   Keywords:  bridgedb-https, bridgedb-0.1.5
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------------------
Changes (by isis):

 * status:  new => accepted
 * owner:   => isis
 * keywords:   => bridgedb-https, bridgedb-0.1.5


Comment:

 Replying to [comment:1 sysrqb]:
 > bug10834 in my repo.

 Merged for 0.1.5 [here
 https://gitweb.torproject.org/bridgedb.git/commit/2b8b557c2bd3526029b2a09bb48ba95c9e20ff3e].
 Thanks!

 I think it all looks okay, and I did a bunch of manual testing to make
 sure the web server was still functioning correctly. I have not yet staged
 it to test with the real descriptors.

 > Mocking HTTPServer will be some work, the methods and functions aren't
 easily testable right now.
 >
 > [0] https://travis-ci.org/sysrqbci/bridgedb/builds/18452368 (2.6 failed)

 I removed Python2.6 from `.travis.yml` because we have 2.7 and there's no
 reason to continue to worry about 2.6 bugs. :)

 I'll try to look at finding a good way to mock `HTTPServer` and the
 objects it touches while travelling tomorrow. IIRC I found a good Twisted-
 compatible way to do this in ooni, but off the top of my head I don't
 remember and I'll probably need to dig a bit.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10834#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online