[tor-bugs] #11048 [Tor]: Thread-safety in log_backtrace()

[Tor Bug Tracker & Wiki]

#11048: Thread-safety in log_backtrace()
-----------------------+------------------------------------
 Reporter:  nickm      |          Owner:
     Type:  defect     |         Status:  new
 Priority:  normal     |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor        |        Version:
 Keywords:  tor-relay  |  Actual Points:
Parent ID:  #11046     |         Points:
-----------------------+------------------------------------
 On #9299, cypherpunks reports:

 >log_backtrace() is thread unsafe. If threads going to assert for the same
 time then calling of backtrace() from every thread going to fill the same
 cb_buf array.

 Our options here are:

   * Add a lock.
   * Make the cb_buf field non-static, and hope that the stack won't mind.

 The first option looks better, I think

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11048>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online