[tor-bugs] #10801 [Tor]: parse_bridge_line() does tor_addr_port_lookup(). Perhaps it should parse, not lookup.

[Tor Bug Tracker & Wiki]

#10801: parse_bridge_line() does tor_addr_port_lookup(). Perhaps it should parse,
not lookup.
-------------------------------------+------------------------------------
 Reporter:  nickm                    |          Owner:
     Type:  defect                   |         Status:  new
 Priority:  normal                   |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor                      |        Version:
 Keywords:  tor-client 024-backport  |  Actual Points:
Parent ID:                           |         Points:
-------------------------------------+------------------------------------
 The tor_addr_port_lookup() function uses the DNS resolver if it receives a
 hostname.  We don't want to support hostnames in bridge addresses, do we?
 Nothing in our spec says we do, does it?

 Alternatively, if we *do* want to support hostnames, we should drop the
 test in test_config.c that does:
 {{{
     bad_bridge_line_test("a.b.c.d");
 }}}

 Since being on a DNS-hijacking cafe wifi seems to make the test fail, when
 a.b.c.d _does_ resolve to something.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10801>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online