[tor-bugs] #13718 [Tor]: Reachability Tests aren't conducted if there are no exit nodes
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Dec 29 17:31:59 UTC 2014
#13718: Reachability Tests aren't conducted if there are no exit nodes
-------------------------+-------------------------------------------------
Reporter: tom | Owner: teor
Type: defect | Status: needs_review
Priority: normal | Milestone: Tor: 0.2.6.x-final
Component: Tor | Version: Tor: 0.2.6.1-alpha
Resolution: | Keywords: tor-relay test-network lorax
Actual Points: | chutney 026-deferrable
Points: | Parent ID: #14034
-------------------------+-------------------------------------------------
Comment (by nickm):
Hi! Everything below is something I can do when merging; I'd just like
your feedback before I do so.
4a41976753c9e916acf12d6156be5fab7f534f07
* The parenthesis bug me a little on the conditional. Maybe put the
whole inequality on a single line. (minor)
fc92ba6b9c9d85c546b94096e6d9bf76a3f38e47
* the message should probably be a notice again (minor)
f93b46adac531406e1cc13668ceecd3e5fca650a
* The expression for setting have_path is pretty complex; I'd like to
turn that into a function that uses a set of ifs. (minor)
Do you agree with these changes? If so I think I can go ahead and merge
and tweak.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13718#comment:46>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list