[tor-bugs] #12848 [Tor]: Tor wrongly process circuit as connected to n_chan if create cell delivery failed

[Tor Bug Tracker & Wiki]

#12848: Tor wrongly process circuit as connected to n_chan if create cell delivery
failed
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:
  cypherpunks            |     Status:  needs_review
         Type:  defect   |  Milestone:  Tor: 0.2.4.x-final
     Priority:  normal   |    Version:  Tor: 0.2.5.5-alpha
    Component:  Tor      |   Keywords:  tor-relay 024-backport 023-backport
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by cypherpunks):

 `circuit_n_chan_done` need to fix too? It does
 {{{
 circ->n_chan = chan;
 }}}
 then calls `circuit_mark_for_close` if `circuit_send_next_onion_skin` or
 `circuit_deliver_create_cell` failed

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12848#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online