[tor-bugs] #13667 [Tor]: Prevent port scanning of hidden services

[Tor Bug Tracker & Wiki]

#13667: Prevent port scanning of hidden services
------------------------+------------------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  major   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  SponsorR tor-hs 025-backport
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------------------

Comment (by dgoulet):

 That means you have two values in the ABI for the same return code but
 behaves differently which will probably end up confusing some people when
 adding code or reviewing it I think. And it gets crazier when at some
 point in time you end up to -260 for a legitimate reasons (or other code).
 I feel that this could simply be an other ticket for a discussion on that
 and at some point a fix.

 However, the fix for this current issue for now, I feel should be closing
 the circuit right away with NONE (current patch in bug13667_025_v2) or
 returning END_CIRC_AT_ORIGIN for a negative value and let the caller close
 the circuit.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13667#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online