[tor-bugs] #12620 [Tor Browser]: Rebase TBB patches to Firefox 31 and add unit tests
Tor Bug Tracker & Wiki
blackhole at torproject.org
Fri Aug 29 19:14:34 UTC 2014
#12620: Rebase TBB patches to Firefox 31 and add unit tests
-------------------------+-------------------------------------------------
Reporter: gk | Owner: tbb-team
Type: task | Status: new
Priority: major | Milestone:
Component: Tor | Version:
Browser | Keywords: TorBrowserTeam201408D, ff31-esr,
Resolution: | tbb-rebase, tbb-firefox-patch
Actual Points: | Parent ID:
Points: |
-------------------------+-------------------------------------------------
Comment (by arthuredelstein):
In trying to apply [https://gitweb.torproject.org/tor-
browser.git/commit/b1f011d993b4a00db2cb50c49dea38ec5188fdb0 "Backport two
integer overflow patches], I found that the [https://gitweb.torproject.org
/tor-
browser.git/blobdiff/3b338aadd92ac0c3d9584fceea28f8934cdf20f0..b1f011d993b4a00db2cb50c49dea38ec5188fdb0:/js/src/vm
/Interpreter-inl.h part in Interpreter-inl.h] doesn't apply to ESR31. The
code in the Interpreter has changed substantially. I think that the
current version of AddOperation does not protect overflow (which looks
like a possible security regression for Mozilla), but it will require
careful study to understand.
The rest of the patch is [https://hg.mozilla.org/mozilla-
central/rev/c00387255d25 already in ESR31].
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12620#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list