[tor-bugs] #12535 [Pluggable transport]: goptlib should expose a SOCKS5 server instead of SOCKS4a.

[Tor Bug Tracker & Wiki]

#12535: goptlib should expose a SOCKS5 server instead of SOCKS4a.
-------------------------------------+----------------------------
     Reporter:  yawning              |      Owner:  yawning
         Type:  defect               |     Status:  needs_review
     Priority:  normal               |  Milestone:
    Component:  Pluggable transport  |    Version:
   Resolution:                       |   Keywords:  goptlib, socks
Actual Points:                       |  Parent ID:  #12130
       Points:                       |
-------------------------------------+----------------------------
Changes (by yawning):

 * status:  new => needs_review


Comment:

 Ok, I cribbed the obfsproxy socks5 unit tests and fixed some minor bugs
 and cleaned up behavior in a few places.  The SOCKS5 protocol handling
 code should have reasonable coverage now, though the goroutine/channel
 related goo does not (not sure what the best way to test that sort of
 thing is).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12535#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online