[tor-bugs] #11633 [Tor]: Quench a few warnings found with gcc-4.2 and clang
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Apr 28 14:32:11 UTC 2014
#11633: Quench a few warnings found with gcc-4.2 and clang
--------------------+------------------------------------
Reporter: _x3j11 | Owner:
Type: defect | Status: new
Priority: normal | Milestone: Tor: 0.2.5.x-final
Component: Tor | Version:
Keywords: | Actual Points:
Parent ID: | Points:
--------------------+------------------------------------
On running configure --enable-gcc-warnings with gcc-4.2 on OpenBSD, as
well as clang 3.3, has picked up a few things:
* gcc-4.2 complains about discarding constness with TO_ORIGIN_CIRCUIT and
TO_OR_CIRCUIT.
* clang complains with -Wshorten-64-to-32 about implicit conversions
between time_t and long, and OpenBSD has time_t as an int32_t.
The attached patches add a const version of TO_ORIGIN_CIRCUIT and
TO_OR_CIRCUIT, and add explicit casts between long and time_t.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11633>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list