[tor-bugs] #10268 [Tor]: tor's dnsserv returns NOTIMPL for queries of type ALL and MX

[Tor Bug Tracker & Wiki]

#10268: tor's dnsserv returns NOTIMPL for queries of type ALL and MX
-------------------------+-------------------------------------------------
     Reporter:  epoch    |      Owner:
         Type:           |     Status:  needs_review
  enhancement            |  Milestone:  Tor: 0.2.5.x-final
     Priority:  normal   |    Version:  Tor: unspecified
    Component:  Tor      |   Keywords:  tor-client, dns, dnsport,
   Resolution:           |  025-triaged, andrea-review-0254
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by andrea):

 Review:

  - The if (!q) case to send a NOTIMPL can only happen if req->nquestions
 == 0 or if all of the questions either have req->questions[i] == NULL or
 req->questions[i]->dns_question_class != EVDNS_CLASS_INET.  I suppose the
 last case is the one that can actually happen if a client still cares
 about CHAOS or HESIOD for some reason, and so the if (!q) { NOTIMPL }  bit
 isn't dead code?

  - Aside from the above inquiry, this all looks okay to me in lieu of
 actually doing proposal 219 properly.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10268#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online