[tor-bugs] #8956 [Obfsproxy]: obfsproxy should use a SOCKS proxy if Tor wants it to

[Tor Bug Tracker & Wiki]

#8956: obfsproxy should use a SOCKS proxy if Tor wants it to
---------------------------+----------------------------
     Reporter:  asn        |      Owner:  asn
         Type:  task       |     Status:  needs_revision
     Priority:  normal     |  Milestone:
    Component:  Obfsproxy  |    Version:
   Resolution:             |   Keywords:
Actual Points:             |  Parent ID:  #8402
       Points:             |
---------------------------+----------------------------

Comment (by asn):

 Replying to [comment:4 yawning]:
 > obfsproxy changes to support this:
 https://github.com/Yawning/obfsproxy/tree/bug_8956
 >
 > The bulk of the credit goes to hellais, I just updated it to use my
 pyptlib changes and the new SOCKS5 code.  Next up, HTTP CONNECT, then on
 to patching tor.

 How do you feel about `bug8956_tweak` in my repo? It kills `settings.py`
 and moves the state-keeping to `TransportConfig`. I think that makes more
 sense, since we've been using `TransportConfig` for similar reasons
 anyway.

 While doing so, I removed the functionality of having both `--proxy` and
 `managed` mode. I did so because it simplified code (the `TransportConfig`
 in managed mode is created way after CLI parsing), and also because it
 seems like a not very useful feature (the managed-proxy protocol should be
 instructing obfsproxy to use a proxy, not the CLI).

 I haven't tested my branch yet.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8956#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online