[tor-bugs] #10769 [Tor Weather]: write weathers emails to a file
Tor Bug Tracker & Wiki
blackhole at torproject.org
Sat Apr 5 09:40:50 UTC 2014
#10769: write weathers emails to a file
-----------------------------+-----------------------------
Reporter: feverDream | Owner: feverDream
Type: enhancement | Status: assigned
Priority: normal | Milestone:
Component: Tor Weather | Version:
Resolution: | Keywords: weather-rewrite
Actual Points: | Parent ID:
Points: |
-----------------------------+-----------------------------
Comment (by karsten):
There are a few issues with that commit:
- We cannot comment out settings in `weather/config/config.py` until we
actually moved to Onionoo. What if somebody takes this branch and tries
to deploy Weather? It won't work at all.
- Rather than commenting out code or settings, we should simply remove
them. That's for the future, though, when we can actually get rid of
them.
- I'm unclear why you changed the path to the database. That's going to
break the existing deployment whenever somebody does `git pull`. We
shouldn't do that. We should rather stick to the existing directory
layout with `/../var/` even though it's not pretty.
- Maybe we should also write emails somewhere to `/../var/`? It seems
that Weather currently doesn't write anything to the cloned directory
root, but only to `/../var/`. If that is the case, let's not clutter up
`/.`.
So, I guess a commit that only adds the `EMAIL_BACKEND` and
`EMAIL_FILE_PATH` lines to `settings.py` but with the right directory to
write emails to would be fine to merge.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10769#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list