[tor-bugs] #9683 [Tor]: circuit_unlink_all_from_channel() is a performance bottleneck?

[Tor Bug Tracker & Wiki]

#9683: circuit_unlink_all_from_channel() is a performance bottleneck?
------------------------+------------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  major   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-relay 024-backport
Actual Points:          |  Parent ID:
       Points:          |
------------------------+------------------------------------

Comment (by andrea):

 Test relay dies with this:

 {{{
 Sep 25 04:04:37.000 [warn] circuit_unlink_all_from_channel(): Bug:
 Mismatch in list of detached circuits.
 Sep 25 04:04:37.000 [warn] circuit_unlink_all_from_channel(): Bug: Circuit
 on detached list which I had no reason to mark
 Sep 25 04:05:38.000 [err] channel_tls_from_base(): Bug:
 src/or/channeltls.c:319: channel_tls_from_base: Assertion chan->magic ==
 TLS_CHAN_MAGIC failed; aborting.
 }}}

 Probably a memory overrun stomping the channel.  Obviously I shouldn't
 review code at 3 AM.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9683#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online