[tor-bugs] #9798 [Tor]: Directory authorities on master are causing clock skew warns on every reachability test

[Tor Bug Tracker & Wiki]

#9798: Directory authorities on master are causing clock skew warns on every
reachability test
------------------------+--------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.4.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-auth
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by arma):

 Ok! Now that things are a bit calmer. One option is
 {{{
 -  /* Timestamp. */
 -  set_uint32(cell.payload, htonl((uint32_t)now));
 +  /* Timestamp, if we're a relay. */
 +  if (public_server_mode(get_options() ||
 !conn->handshake_state->started_here)
 +    set_uint32(cell.payload, htonl((uint32_t)now));
 }}}

 Then bridges set the timestamp when somebody connects to them, but they
 act like a client they connect to somebody.

 I see a bit lower in connection_or_send_netinfo() that we have another
 very similar-looking check, where we look at
 {{{
   if ((public_server_mode(get_options()) || !conn->is_outgoing) && [...]
 }}}

 Maybe we should use !conn->is_outgoing in both cases, for uniformity?
 Unless they ever differ from each other?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9798#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online