[tor-bugs] #9774 [Tor]: Explain "#ifdef CURVE25519_ENABLED" better

[Tor Bug Tracker & Wiki]

#9774: Explain "#ifdef CURVE25519_ENABLED" better
------------------------+--------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-relay
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by nickm):

 CURVE25519_ENABLED doesn't mean "Can we do ntor handshakes" -- it
 literally means "Is curve25519 enabled; did we compile with curve25519
 support?"  It ''is'' a matter of fact that we build the code for the ntor
 handshake iff we have curve25519 enabled, but that's another matter.

 I'm not sure what non-#ifdef'd code in specific you're talking about. The
 ntor code that isn't covered by #ifdefs is supposed to be related to
 moving ntor keys around, storing them, and so forth.  The onion_ntor.c
 file itself is conditionally compiled -- see src/or/include.am.


 Replying to [comment:1 arma]:
 > (Giving it a subcomponent keyword since Nick wants all Tor tickets to
 have one)

 I thought you were the one who wanted subcomponents?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9774#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online