[tor-bugs] #9249 [Tor]: GSOC seccomp stage 2

[Tor Bug Tracker & Wiki]

#9249: GSOC seccomp stage 2
-----------------------------+--------------------------------------------
     Reporter:  ctoader      |      Owner:  nickm
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-relay gsoc seccomp sandbox
Actual Points:               |  Parent ID:  #5756
       Points:               |
-----------------------------+--------------------------------------------

Comment (by nickm):

 Replying to [comment:9 ctoader]:
 > I added comments at the end of each item describing their state. I need
 a bit of feedback, wasn't able to fully complete 2 items. Please let me
 know as soon as you can what I should do. I have also fixed a few bugs,
 might be worth looking over the commit history.
 >
 > Looking forward to a response!
 >
 > Replying to [comment:8 nickm]:
 > > * Do we truly only use getaddrinfo in the code to look up our own
 address?
 > Probably not, but the calls are many and complicated, do you have a
 suggestion as how to approach this? So far I have added extra logging for
 whenever a sandbox_getaddrinfo() is not successful and also I have
 implemented a way to allow storing more than one result.

 Looks good. We can clean these up as we go.

 > > * Prefer TOR_SLIST or TOR_SINGLEQ to manually managing a linked list.
 (They're defined in src/ext/tor_queue.h)
 > I found it very difficult to use the macros in tor_queue.h; also they
 modify the data structures a bit, is this a requirement or is it possible
 for the code to be accepted as is from this point of view. Everything
 seems much clearer to me without the macros but I would guess that someone
 familiar with them would think otherwise. Please let me know..

 Okay; I'm happy to clean this up later.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9249#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online