[tor-bugs] #9650 [Tor]: create_managed_proxy_environment: lack of checks for values returned by get_first_listener_addrport_string

[Tor Bug Tracker & Wiki]

#9650: create_managed_proxy_environment: lack of checks for values returned by
get_first_listener_addrport_string
-------------------------+------------------------------------
 Reporter:  cypherpunks  |          Owner:
     Type:  defect       |         Status:  new
 Priority:  normal       |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor          |        Version:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
-------------------------+------------------------------------
 get_first_listener_addrport_string() can return NULL according to it's
 documentation.
 No checks in create_managed_proxy_environment() so NULL can be passed to
 smartlist_add_asprintf()

 If you sure NULL never returns for such case then it needs proper assert
 check at least.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9650>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online