[tor-bugs] #6877 [Tor]: Finally replace all char[] buffers with uint8_t[] buffers

[Tor Bug Tracker & Wiki]

#6877: Finally replace all char[] buffers with uint8_t[] buffers
------------------------+--------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  major   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-client
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by unixninja92):

 Replying to [comment:9 nickm]:
 > c48c2fb5979ad7189fb9f37a25e250e9379ad9eb:
 >   * Looks okay.
 >   * For crypto_digest_smartlist, since it's defined to take a list of
 NUL-terminated strings, I think it makes sense to have them remain char*.
 I made *append a char for crypto_dyget_smartlist again in
 299de8cafb60bab080268dfef8a3f371e34439de. I left *digest_out as a uinit_8
 because all the other digests in crypto are now uinit_8 and it would
 require a lot of casting to change it.
 >
 > 24f08854b9e3efa94158ccb9b1f161f1a27b5e4a:
 >   * Wow, that's a big one...
 >   * In dirvote.c, since fingerprint is a hex string, it probably makes
 sense to have it stay char.
 This should be fixed in 6211cd4e1d8c093e64ee6cf0195694c08abb57ed.
 >   * Otherwise looks okay.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6877#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online