[tor-bugs] #9959 [BridgeDB]: BridgeDB seems to be missing English translations

[Tor Bug Tracker & Wiki]

#9959: BridgeDB seems to be missing English translations
-------------------------+-------------------------------------------------
     Reporter:  isis     |      Owner:  isis
         Type:  defect   |     Status:  needs_review
     Priority:  blocker  |  Milestone:
    Component:           |    Version:
  BridgeDB               |   Keywords:  bridgedb-ui, bridgedb-translations,
   Resolution:           |  translations, bridgedb-https
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by isis):

 Replying to [comment:3 aagbsn]:
 > I believe these were how we did translation before, and install_data
 points at the method installData in setup.py that is made redundant by the
 package_data directive in setup().
 >
 > >
 > > I'm not sure what `trans` was supposed to do, nor can I find reference
 to a distutils command class anywhere for that, so I assumed it was
 something from an old python gettext-ish module that was removed/replaced
 at some point.
 >
 > I think that sounds accurate.
 >

 Okay, I'll just remove those then.


 > > Hrm. I fixed it by creating "untranslated" .po files for `en`, `en_GB`
 and `en_US`. Which seems like madness to me, and I can't for the life of
 me (I already bisected twice) figure out why BridgeDB all of a sudden
 wants translation files for English. But it's working again at least.
 >
 > Well, sounds like that will work. Were translations broken even after
 you rolled back to a prior commit and did a clean install?
 >

 Yes, which is why I believe that this is a bug or API change in something
 else, in Twisted/FF/pybabel/etc.



 > > One strange thing that I noticed, if you look at
 [https://trac.torproject.org/projects/tor/ticket/9157#comment:19 my
 comment on #9517] which links to this ticket, is that all of the languages
 in the `Accept-Language` header have a `q` weight assigned to them -- all
 except for `en`, the first one. I had assumed that this was an implied
 `en;q=1` meaning "primary preference"...but maybe it just wasn't ever
 assigned a weight at all. If that is the case...beetlejuice, that bug
 could be anywhere...in BridgeDB, in Twisted, in Firefox, in pybabel...ugh.
 But it's fixed so "no happy; be worry" as they always say, right?
 >
 > Hm, how many languages are present in your Accept-Language header?

 Something around twenty. Is that a problem?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9959#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online