[tor-bugs] #9971 [Tor]: for_discovery option in add_an_entry_guard() is confusingly named

[Tor Bug Tracker & Wiki]

#9971: for_discovery option in add_an_entry_guard() is confusingly named
------------------------+------------------------------------
 Reporter:  arma        |          Owner:
     Type:  defect      |         Status:  new
 Priority:  minor       |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor         |        Version:
 Keywords:  tor-client  |  Actual Points:
Parent ID:              |         Points:
------------------------+------------------------------------
 In #9946 I added a new argument "for_discovery" to add_an_entry_guard().
 Nick prefers "provisional" or "probationary".

 In parallel, I think we should probably rename the made_contact field in
 entry guard t, to be *why* we're remembering that we've made contact,
 rather than simply that we have.

 And lastly, we should do something about the godawful number of int
 arguments that add_an_entry_guard() now takes.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9971>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online