[tor-bugs] #9925 [Tor]: Directory Authorities can crash client/relay

[Tor Bug Tracker & Wiki]

#9925: Directory Authorities can crash client/relay
------------------------+--------------------------------
     Reporter:  sysrqb  |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by sysrqb):

 1d9ccb1a99a7590f8269d7dfeabf976836e9891f:
   - The warning message says "Dropping old descriptor to fetch another,
 but this probably won't work." but we don't actually fetch it. Should we?
 Or is this a "we'll get it next time"? Or am I misinterpreting "fetch
 another" to mean "refetch the descriptor" but it really means "skip this
 one and fetch the next routers' descriptor"?

 016c4dcbcddc391515e2fdd0f28832679ab2fae5:
   - Is there a reason to pass seen_descriptor_digests as a parameter? It
 seems that it is always local to the calling function and never used (only
 freed) on return.
   - In the commit message s/and/can/ second paragraph.

 Otherwise I think this does what it says.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9925#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online