[tor-bugs] #8692 [Stem]: ONLINE integ target fails
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu May 30 15:51:43 UTC 2013
#8692: ONLINE integ target fails
-----------------------+----------------------------------------------------
Reporter: atagar | Owner: atagar
Type: defect | Status: closed
Priority: minor | Milestone:
Component: Stem | Version:
Resolution: fixed | Keywords: testing easy
Parent: | Points:
Actualpoints: |
-----------------------+----------------------------------------------------
Changes (by atagar):
* status: needs_review => closed
* resolution: => fixed
Comment:
Hazza, passing tests! Thanks for the fix Jeremy. Squashed your commits and
pushed with some very minor tweaks...
https://gitweb.torproject.org/stem.git/commitdiff/2257f7954a0d9dba46905a4813b828fcc0b52086
{{{
STATIC CHECKS
* /home/atagar/Desktop/stem/test/integ/control/controller.py
line 817 - W293 blank line contains whitespace
line 821 - W293 blank line contains whitespace
}}}
If you have pep8 installed and run either 'run_tests.py --style' or
'run_tests.py --all' stem will check for any style issues.
{{{
for _ in range(10):
}}}
When using range in a loop xrange() is preferable. The range() function
provides a list and xrange() an iterator. In this case it doesn't make a
difference, but when dealing with large ranges (say, range(90000)) it can
improve performance a bit.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8692#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list