[tor-bugs] #8948 [Tor]: Write a "code review guidelines" page

Tor Bug Tracker & Wiki blackhole at torproject.org
Sat May 25 23:33:07 UTC 2013


#8948: Write a "code review guidelines" page
-------------------------+--------------------------------------------------
 Reporter:  nickm        |          Owner:                    
     Type:  enhancement  |         Status:  new               
 Priority:  normal       |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor          |        Version:                    
 Keywords:               |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------

Comment(by rransom):

 Replying to [comment:3 atagar]:

 > In short, if tor has requirements that you want followed prior to
 sending code reviews then imho it should be a simple make target, not a
 wall of text.

 Most of them are in `doc/HACKING`, in the ‘Patch checklist’ section.  Some
 of the checklist items (at least “include a file in the "changes"
 directory as appropriate”) cannot be automated.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8948#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list