[tor-bugs] #8639 [Tor]: Controller: Stream event source field is "<unknown address type>:1" for DNS requests from the controller

[Tor Bug Tracker & Wiki]

#8639: Controller: Stream event source field is "<unknown address type>:1" for DNS
requests from the controller
---------------------------------+------------------------------------------
 Reporter:  Desoxy               |          Owner:  andrea             
     Type:  defect               |         Status:  needs_review       
 Priority:  normal               |      Milestone:  Tor: 0.2.4.x-final 
Component:  Tor                  |        Version:  Tor: 0.2.4.11-alpha
 Keywords:  tor-spec tor-client  |         Parent:                     
   Points:                       |   Actualpoints:                     
---------------------------------+------------------------------------------

Comment(by nickm):

 Oh hang on; I'd worry that stuff will crash if there are connections with
 address == NULL flying around the code.  Look for ->address in
 connection.c for example, and consider all the places we use it without
 checking for whether it's NULL.

 What if we took the first version of your patch, and added the control.c
 changes from the second version, but checked for
 !strcmp(..,"(Tor_internal)") instead of NULL?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8639#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online