[tor-bugs] #8880 [Tor]: Fix log message saying what fraction of paths we can likely build

[Tor Bug Tracker & Wiki]

#8880: Fix log message saying what fraction of paths we can likely build
-------------------------------+--------------------------------------------
 Reporter:  karsten            |          Owner:                    
     Type:  defect             |         Status:  needs_information 
 Priority:  normal             |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor                |        Version:                    
 Keywords:  tor-client shadow  |         Parent:                    
   Points:                     |   Actualpoints:                    
-------------------------------+--------------------------------------------

Comment(by robgjansen):

 I very briefly looked at the code (the %d%% is causing problems). Shadow
 intercepts Tor's 'logv' function, but doesn't call 'format_msg'. Is that
 the issue? Otherwise, Shadow takes the va_list and passes it to g_logv,
 which I assume should handle the %d%% format correctly.

 This is where I wish Tor was slightly more modular (read: Shadow could
 selectively intercept functions). Shadow intercepts the 'logv' function in
 'log.c' so that it can push the log message through the simulator's
 logging mechanism. That means every time changes are made to logv,
 Shadow's version becomes out of date. Ideally [for Shadow], the
 'write_all' at the end of 'logv' would be moved to a new 'logv_write_all'
 function. Then, Shadow could intercept 'logv_write_all' and reduce code
 duplication on Shadow's end.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8880#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online