[tor-bugs] #8478 [TorBrowserButton]: Tor Browser Bundle on OS X 10.6 does not set resolution to a multiple of 200x100

Tor Bug Tracker & Wiki blackhole at torproject.org
Sat May 11 20:28:53 UTC 2013


#8478: Tor Browser Bundle on OS X 10.6 does not set resolution to a multiple of
200x100
------------------------------------------------------------------------+---
 Reporter:  cypherpunks                                                 |          Owner:  mikeperry
     Type:  defect                                                      |         Status:  assigned 
 Priority:  critical                                                    |      Milestone:           
Component:  TorBrowserButton                                            |        Version:           
 Keywords:  tbb-fingerprinting, tbb-rebase-regression, MikePerry201305  |         Parent:           
   Points:                                                              |   Actualpoints:           
------------------------------------------------------------------------+---

Comment(by gk):

 Resizing the window in onStateChange() (with a STATE_STOP flag)
 (WebProgressListener) works for me on Linux and Mac OS X reliably without
 the resizing being visible ("xul-window-visible" is broadcasted in
 SetVisibility() in nsXULWindow.cpp which gets called by OnChromeLoaded()
 which in turn gets called in onStateChange() (see: nsWebShellWindow.cpp
 for the latter). Only on Windows the height is still smaller (2px!!, wtf)
 as expected. If I can't come up with a cleaner solution, resizing again
 with setTimeout(0) (still in onStateChange()) might be good enough as I
 doubt increasing the height by 2px once is annoying users. Doing that
 additional resizing with setTimeout(0) might be a good idea in general, as
 a "defense in depth", if the other hackery is still to racy or gets broken
 by some changes in underlying Mozilla code...

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8478#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list