[tor-bugs] #6402 [Tor Sysadmin Team]: set up a code review tool

[Tor Bug Tracker & Wiki]

#6402: set up a code review tool
----------------------------------+-----------------------------------------
    Reporter:  gsathya            |       Owner:          
        Type:  task               |      Status:  reopened
    Priority:  normal             |   Milestone:          
   Component:  Tor Sysadmin Team  |     Version:          
  Resolution:                     |    Keywords:          
      Parent:                     |      Points:          
Actualpoints:                     |  
----------------------------------+-----------------------------------------
Changes (by gsathya):

  * status:  closed => reopened
  * resolution:  wontfix =>


Comment:

 Replying to [comment:6 StrangeCharm]:
 > I'm marking this as "wontfix" for now. I'm not convinced that picking or
 setting up a tool is going to fix things. I'd rather work on the actual
 process, and if we find that our process really needs gerrit, let's set up
 gerrit. Process first, tools later.

 I agree. I'm reopening this ticket to discuss the process. (Or feel free
 to open a new ticket for this)

 The process to contribute is -
 1) clone the git repo
 2) create a feature branch
 3) hack
 4) push the branch
 5) link the branch in a ticket and change status to 'needs_review'

 The review process is -
 1) pull the branch
 2) view the diff in your favorite editor
 3) copy paste the diffs on the ticket with comments inline
 4) change status to 'needs_revision'

 I don't think this "copy paste the diffs on the ticket with comments
 inline" works at all, the rest is ok. I hate the whole copy pasting of
 diffs -- this should all be automated. Also, for the contributor It's
 weirdly hard to figure out which part of code the diffs refer to. I've
 started using github because of this and link to the compare view instead
 of the branch, so the reviewer can quickly see what changes I've done and
 see how much time it's going to take to review that.

 I'd like to know your thoughts on improving this process :)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6402#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online