[tor-bugs] #8380 [Tor]: DNS A records returned when asking for AAAA

[Tor Bug Tracker & Wiki]

#8380: DNS A records returned when asking for AAAA
-----------------------------------------+----------------------------------
 Reporter:  dhill                        |          Owner:                    
     Type:  defect                       |         Status:  new               
 Priority:  normal                       |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor                          |        Version:  Tor: unspecified  
 Keywords:  DNSPort dns ipv6 tor-client  |         Parent:                    
   Points:                               |   Actualpoints:                    
-----------------------------------------+----------------------------------

Comment(by nickm):

 So looking at the code in send_resolved_cell, I think we're cool there: we
 send back an IPv4 addr if we have that, and an IPv6 addr if we have that,
 and both if we have both.

 Looking at the code in connection_ap_process_not_open() that handles
 RESOLVED cells, it appears that we're calling
 connection_ap_handshake_socks_resolved() with the first answer only, and
 ignoring subsequent answers.

 It appears that dnsserv_resolved() can handle all answer types.

 The right fix here will involve refactoring
 connection_ap_process_not_open() tand
 connection_ap_handshake_socks_resolved() a fair bit.

 I'm inclined to call this an unimplemented feature and therefore put it
 into 0.2.5, not 0.2.4.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8380#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online