[tor-bugs] #8117 [Tor]: Tor SOCKS handshake makes SOCKS circuit isolation non-functional for many apps

[Tor Bug Tracker & Wiki]

#8117: Tor SOCKS handshake makes SOCKS circuit isolation non-functional for many
apps
-----------------------------------------------+----------------------------
 Reporter:  cypherpunks                        |          Owner:                    
     Type:  defect                             |         Status:  needs_review      
 Priority:  major                              |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor                                |        Version:  Tor: 0.2.3.25     
 Keywords:  tor-client isolation 023-backport  |         Parent:                    
   Points:                                     |   Actualpoints:                    
-----------------------------------------------+----------------------------

Comment(by nickm):

 To be clear: I don't think we should merge this if it will break things
 that work today for a substantial number of users.  I've tried the "break
 the nonconformant apps, and write patches as needed" approach to making
 only-nonfonformant-apps-will-break changes in the past, and it just mades
 for a huge pile of pain.

 If this patch breaks something significant, the right fix is IMO to have
 it be enabled or disabled on a per-SOCKS-listener basis, so that if you
 need to run any applications that can't handle this fix, you can point
 them at a SOCKS port that doesn't have this fix turned on.  It'll be more
 code, but potentially far less effort than upstreaming a big pile of fixes
 and/or upsetting a big mass of users.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8117#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online