[tor-bugs] #3594 [Tor]: Add support for SOCKS parameters in Bridge and {Client, Server}TransportPlugin lines

[Tor Bug Tracker & Wiki]

#3594: Add support for SOCKS parameters in Bridge and
{Client,Server}TransportPlugin lines
---------------------------+------------------------------------------------
 Reporter:  asn            |          Owner:                    
     Type:  enhancement    |         Status:  needs_review      
 Priority:  normal         |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor            |        Version:                    
 Keywords:  pt tor-bridge  |         Parent:  #7211             
   Points:                 |   Actualpoints:                    
---------------------------+------------------------------------------------

Comment(by asn):

 After reading #7153 and looking at
 `faf4f6c6d1da54b0a6b0c9946112f2e448867a8f`, I see that in
 `validate_transport_socks_arguments()` I reject SOCKS arguments larger
 than `MAX_SOCKS5_AUTH_SIZE_TOTAL` even if I don't know the SOCKS version
 that the pluggable transport proxy is going to use. Maybe this check
 shouldn't happen in `validate_transport_socks_arguments()` so that we
 allow large SOCKS arguments if SOCKS4a is used.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3594#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online