[tor-bugs] #8435 [Tor]: Ignore advertised bandwidths for flags once we have enough measured bandwidths

[Tor Bug Tracker & Wiki]

#8435: Ignore advertised bandwidths for flags once we have enough measured
bandwidths
-------------------------+--------------------------------------------------
 Reporter:  andrea       |          Owner:                    
     Type:  enhancement  |         Status:  new               
 Priority:  major        |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor          |        Version:  Tor: unspecified  
 Keywords:  tor-auth     |         Parent:                    
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------

Comment(by andrea):

 There are three calls to set_routerstatus_from_routerinfo(); one is in a
 loop in dirserv_generate_networkstatus_vote_obj() after we
 dirserv_read_measured_bandwidths(), so we can insert whatever calculations
 are needed there.  Another is in generate_v2_networkstatus_opinion(),
 which should never care about this, and the third is in
 networkstatus_getinfo_by_purpose(), which comes with a comment that
 explicitly says it should only be used for bridges, so measured bandwidths
 won't apply here.

 I think we should just have an dirserv_update_bw_trust() that gets called
 from dirserv_generate_networkstatus_vote_obj() after
 dirserv_read_measured_bandwidths() but before the
 set_routerstatus_from_routerinfo() loop to calculate the proportion and
 decide if advertised bandwidths are acceptable, and then have
 set_routerstatus_from_routerinfo() use a new
 dirserv_get_trusted_bandwidth_for_router() that checks that and returns
 zero if the threshold is met and no measured bandwidth is available.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8435#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online