[tor-bugs] #8401 [Tor bundles/installation]: More closely match official Mozilla Build Machines

[Tor Bug Tracker & Wiki]

#8401: More closely match official Mozilla Build Machines
--------------------------------------+-------------------------------------
 Reporter:  mikeperry                 |          Owner:  erinn
     Type:  project                   |         Status:  new  
 Priority:  normal                    |      Milestone:       
Component:  Tor bundles/installation  |        Version:       
 Keywords:                            |         Parent:       
   Points:                            |   Actualpoints:       
--------------------------------------+-------------------------------------
Changes (by tom):

 * cc: tom@… (added)


Comment:

 Several things.  I think we're really close on this!

 1) Having VS2008 already installed definetly helped you: you had the
 msvc*90*.dll's that ship with it and are referenced in build-
 scripts\windows.mk

 For a true VS2010 build we will need to change the windows.mk file to not
 reference those dlls (c/Program Files (x86)/Microsoft Visual Studio
 9.0/VC/redist/x86/Microsoft.VC90.CRT/"msvc*90.dll) and instead reference
 the msvc*100.dll's.

 These dlls are from the "Microsoft Visual C++ 20xx Redistributable
 Package" - it's fine to require them, and it's fine to redistribute them
 as part of TBB.  I think but am not 100% certain that as long as we build
 with VS2010 they will be perfect replacements for the 90.dll's.

 2) MY crash with xul.dll (see https://lists.torproject.org/pipermail/tor-
 dev/2013-March/004496.html ) was actually do to omni.ja not being packaged
 correctly.  The reason for that I suspect was I futzed and edited MSC_VER
 too late, patch-mozilla-build.sh had already patched the wrong .bat file.
 Once I patched the correct mozilla-build bat file (which is 10 for 2010),
 and ran build-firefox again...

 It crashed/hung in pymake!  Like this:

 {{{
 Administrator at ip-0AF0A24F /c/build/torbrowser/build-scripts
 $ make -f windows.mk build-firefox
 cp config/dot_mozconfig /c/build/torbrowser/build-scripts/build-alpha-
 windows/build/firefox-17.0.3esr/mozconfig
 cp branding/* /c/build/torbrowser/build-scripts/build-alpha-
 windows/build/firefox-17.0.3esr/browser/branding/official
 cd /c/build/torbrowser/build-scripts/build-alpha-windows/build/mozilla-
 build && cmd.exe /c "start-msvc10.bat /c/build/torbrowser/build-scripts
 /build-alpha-windows/build/firefox-17.0.3esr /c/build/torbrowser/build-
 scripts/build-alpha-windows/build/mozilla-build/python/python.exe
 /c/build/torbrowser/build-scripts/build-alpha-
 windows/build/firefox-17.0.3esr/build/pymake/make.py"
 "Mozilla tools directory: c:\build\torbrowser\build-scripts\build-alpha-
 windows\build\mozilla-build\"
 Using VC 2010 built-in SDK
 Setting environment for using Microsoft Visual Studio 2010 x86 tools.
 /c/build/torbrowser/build-scripts/build-alpha-
 windows/build/firefox-17.0.3esr //<== This was a debugging line I put in
 /c/build/torbrowser/build-scripts/build-alpha-windows/build/mozilla-
 build/python/python.exe //<== This was a debugging line I put in
 /c/build/torbrowser/build-scripts/build-alpha-
 windows/build/firefox-17.0.3esr/build/pymake/make.py //<== This was a
 debugging line I put in
 Mozilla build environment: MSVC version 10.
 make.py[1]: Entering directory 'c:\build\torbrowser\build-scripts\build-
 alpha-windows\build\firefox-17.0.3esr'
 evaluation from c:\build\torbrowser\build-scripts\build-alpha-
 windows\build\firefox-17.0.3esr\client.mk:104:0:2:1:Fix above errors
 before continuing.
 make: *** [build-firefox] Error 2
 }}}


 When I run it manually is hangs like this:

 {{{
 Administrator at ip-0AF0A24F /c/build/torbrowser/build-scripts/build-alpha-
 windows/build/firefox-17.0.3esr
 $ /c/build/torbrowser/build-scripts/build-alpha-windows/build/mozilla-
 build/python/python.exe /c/build/torbrowser/build-scripts/build-alpha-
 windows/build/firefox-17.0.3esr/build/pymake/make.py -f client.mk build
 make.py[0]: Entering directory 'c:\build\torbrowser\build-scripts\build-
 alpha-windows\build\firefox-17.0.3esr'
 }}}

 So the pymake crashes seem to be critically important.  I tried doing the
 mingw make, but it died like this:

 {{{
 Administrator at ip-0AF0A24F /c/build/torbrowser/build-scripts/build-alpha-
 windows/build/firefox-17.0.3esr
 $ make -f client.mk build
 client.mk:104: *** Fix above errors before continuing..  Stop.
 }}}

 And I had to stop investigating.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8401#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online