[tor-bugs] #9162 [Tor]: get_configured_bridge_by_addr_port_digest() does not work well if digest == NULL

[Tor Bug Tracker & Wiki]

#9162: get_configured_bridge_by_addr_port_digest() does not work well if digest ==
NULL
---------------------------+------------------------------------------------
 Reporter:  asn            |          Owner:                    
     Type:  defect         |         Status:  new               
 Priority:  normal         |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor            |        Version:                    
 Keywords:  tor-client pt  |         Parent:                    
   Points:                 |   Actualpoints:                    
---------------------------+------------------------------------------------
 `get_configured_bridge_by_addr_port_digest()` returns `NULL` if digest is
 `NULL` (the caller doesn't care about the digest) and `bridge->identity`
 set.

 Normally, the function should return any bridge with addr/port that
 matches even if it has an identity digest set.

 This bug becomes visible when Tor does a second SOCKS request to the
 pluggable transport proxy after it has learned the identity digest of a
 bridge. In that second request, the SOCKS arguments are not passed, since
 `digest == NULL` but `bridge->identity` is set.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9162>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online