[tor-bugs] #7216 [Tor]: networkstatus_check_consensus_signature() shouldn't warn because of missing certs

[Tor Bug Tracker & Wiki]

#7216: networkstatus_check_consensus_signature() shouldn't warn because of missing
certs
-----------------------------+----------------------------------------------
 Reporter:  nickm            |          Owner:                  
     Type:  defect           |         Status:  needs_revision  
 Priority:  normal           |      Milestone:  Tor: unspecified
Component:  Tor              |        Version:                  
 Keywords:  tor-client easy  |         Parent:                  
   Points:                   |   Actualpoints:                  
-----------------------------+----------------------------------------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 Hm.  So the issue is that we don't want to _always_ suppress this message.
 We only want to suppress it in the case where we might succeed in
 verifying the networkstatus if we succeed in downloading one or more of
 the missing certificates that we're downloading right now.

 But we already try to do that with the "(n_good + n_missing_key -
 n_dl_failed_key < n_required)" check above.  Perhaps the problem is how
 our call to authority_cert_dl_looks_uncertain() only looks at the
 authority identity, and not at the desired signing key that we're trying
 to get a certificate for?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7216#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online