[tor-bugs] #4519 [Tor]: circuit_unlink_all_from_orconn is too expensive

[Tor Bug Tracker & Wiki]

#4519: circuit_unlink_all_from_orconn is too expensive
----------------------------+-----------------------------------------------
 Reporter:  nickm           |          Owner:                  
     Type:  defect          |         Status:  needs_review    
 Priority:  major           |      Milestone:  Tor: unspecified
Component:  Tor             |        Version:                  
 Keywords:  easy tor-relay  |         Parent:                  
   Points:                  |   Actualpoints:                  
----------------------------+-----------------------------------------------

Comment(by rransom):

 Replying to [comment:6 marek]:
 > If we want to be able to unlink `circuit_t` without the need of walking
 through all of the circuits, first we need to make `global_circuitlist` a
 doubly-linked list. Attached patch does just that, and improves some other
 minor things:
 >
 >  - Doesn't expose `global_circuitlist` via 'extern', instead calls
 `circuit_get_global_list_()` to get the structure.

 This should be a separate commit/patch, before your other changes.

 >  - Removes unused `circuit_dump_by_chan` and its helper
 `circuit_dump_chan_details`.

 This should be not only a separate commit/patch, but a separate Trac
 ticket.  (Perhaps the real bug here is that those functions are unused.)

 >  - Adds `#include tor_queue.h` to `or.h` as it's needed.
 >
 > I don't think this patch is enough to "resolve" this bug, but is
 definitely necessary.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4519#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online