[tor-bugs] #5129 [Tor]: Avoid fcntl(O_NONBLOCK) calls on Linux

[Tor Bug Tracker & Wiki]

#5129: Avoid fcntl(O_NONBLOCK) calls on Linux
----------------------------+-----------------------------------------------
 Reporter:  nickm           |          Owner:                    
     Type:  enhancement     |         Status:  needs_revision    
 Priority:  minor           |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor             |        Version:                    
 Keywords:  easy tor-relay  |         Parent:                    
   Points:                  |   Actualpoints:                    
----------------------------+-----------------------------------------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 Okay, looks better. Three things I want to do before merging this:

  * The eventdns changes should be wrapped in an #if 1 or something --
 eventdns.c is imported code (snarfed from Libevent 1.x and then patched
 sporadically with fixes from later Libevent versions), and we should
 minimize our changes to it.  In fact, unless the old code is _wrong_ , we
 should really just leave it alone.
  * In several places, the patch uses an #ifdef _WIN32 to decide whether to
 call close() or closesocket(). Ideally, we should have a function or macro
 for that.  This would be tor_close_socket, but without the socket
 accounting.
  * This needs a changes/ file.

 I'll see if I can do these in the next day or two, unless you want to.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5129#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online