[tor-bugs] #5170 [Tor]: crypto_pk_get_digest (et al.?) use i2d_RSAPublicKey obsoletely

Mon Jun 10 16:57:49 UTC 2013

#5170: crypto_pk_get_digest (et al.?) use i2d_RSAPublicKey obsoletely
-----------------------------+----------------------------------------------
 Reporter:  rransom          |          Owner:                    
     Type:  defect           |         Status:  needs_revision    
 Priority:  trivial          |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor              |        Version:                    
 Keywords:  easy tor-client  |         Parent:                    
   Points:                   |   Actualpoints:                    
-----------------------------+----------------------------------------------

Comment(by marek):

 Added tests for everything except `crypto_store_dynamic_dh_modulus` and
 `tor_cert_new`. Writing tests for those functions would be cumbersome and
 pretty much useless - we would end up testing openssl `i2d`/`d2i`
 functions.

 I'm pretty happy with the code now.

 (View changes as a single patch, for easy review:
 https://gist.github.com/majek/5750346 , the changes are under bug5170
 branch on git://github.com/majek/tor.git )

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5170#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online