[tor-bugs] #9288 [Tor]: Invalid memory read in `pt_configure_remaining_proxies()`

[Tor Bug Tracker & Wiki]

#9288: Invalid memory read in `pt_configure_remaining_proxies()`
---------------------------+------------------------------------------------
 Reporter:  asn            |          Owner:                    
     Type:  defect         |         Status:  needs_revision    
 Priority:  major          |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor            |        Version:                    
 Keywords:  tor-client pt  |         Parent:                    
   Points:                 |   Actualpoints:                    
---------------------------+------------------------------------------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 My bug9288 branch builds and doesn't segfault.

 Could we expand the unit tests so that they actually *check* the expected
 outputs?  That is, I expect that configuring a proxy is supposed to result
 in some changes to the proxy, to the or_state_t object, calls to other
 function, and changes or calls to other stuff.  There are lots of bugs
 that could lurk here that wouldn't get tested if all we check for is
 "return 0 five times, then return 1."

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9288#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online